fix partial ring in the progress drawable for the first cycle#30
Open
susonthapa wants to merge 1 commit intorazir:masterfrom
Open
fix partial ring in the progress drawable for the first cycle#30susonthapa wants to merge 1 commit intorazir:masterfrom
susonthapa wants to merge 1 commit intorazir:masterfrom
Conversation
Author
|
@razir Can you please review it ? |
|
It is still possible for the |
raffaelgyr
added a commit
to raffaelgyr/ProgressButton
that referenced
this pull request
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress drawable's ring is only partially displayed for the first rotation as show in the gif below.
I have fixed the issue, it was caused due to multiple calls to the start() function of the drawable (I was so stupid, it took me 3 hours to figure that out). You can see in the gif below, now the progress drawable behaves normally.
Forgive me if the multiple calls to the start() function is intentional.