-
Notifications
You must be signed in to change notification settings - Fork 93
Updated the project to run with Android Studio Otter. #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| EditText etApiKey = findViewById(R.id.et_api_key); | ||
| EditText etCustomOptions = findViewById(R.id.et_custom_options); | ||
|
|
||
| etApiKey.setText("rzp_live_ILgsfZCZoFIKMb"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vivekshindhe need clarity on whether we share our merchant key publicly or not.
| val etApiKey = findViewById<EditText>(R.id.et_api_key) | ||
| val etCustomOptions = findViewById<EditText>(R.id.et_custom_options) | ||
|
|
||
| etApiKey.setText("rzp_live_ILgsfZCZoFIKMb") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded sensitive data leaked
Semgrep has detected a leak of sensitive data in this code. This secret data could be used by internal or external malicious actors. We highly recommend you change, reset, or rotate the sensitive data.
A secret is hard-coded in the application. Secrets stored in source code, such as credentials, identifiers, and other types of sensitive data, can be leaked and used by internal or external malicious actors. It is recommended to rotate the secret and retrieve them from a secure secret vault or Hardware Security Module (HSM), alternatively environment variables can be used if allowed by your company policy.
🔴 Fix or ignore this finding to merge your pull request.
Ignore this finding from string
| EditText etApiKey = findViewById(R.id.et_api_key); | ||
| EditText etCustomOptions = findViewById(R.id.et_custom_options); | ||
|
|
||
| etApiKey.setText("rzp_live_ILgsfZCZoFIKMb"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded sensitive data leaked
Semgrep has detected a leak of sensitive data in this code. This secret data could be used by internal or external malicious actors. We highly recommend you change, reset, or rotate the sensitive data.
A secret is hard-coded in the application. Secrets stored in source code, such as credentials, identifiers, and other types of sensitive data, can be leaked and used by internal or external malicious actors. It is recommended to rotate the secret and retrieve them from a secure secret vault or Hardware Security Module (HSM), alternatively environment variables can be used if allowed by your company policy.
🔴 Fix or ignore this finding to merge your pull request.
Ignore this finding from string
No description provided.