fix(kit): retry transient offline reset locks - #107
Merged
Merged
Conversation
Contributor
Author
|
/devin 再度レビューして。 #104 との関係についても整理して |
Contributor
Co-Authored-By: rdlabo <sakakibara@rdlabo.jp>
Contributor
再レビュー結果(16d746a まで)修正した点(c78525d)混在 AggregateError を即時伝播する 16d746a の方針は妥当ですが、 再現していた 2 ケース(どちらも修正前は const nativeLock = new Error('... message: database is locked');
isTransientSqliteLockError(new AggregateError([
new Error('delete failed', { cause: nativeLock }),
new Error('close failed', { cause: nativeLock }),
])); // 修正前 false → 再試行されない
const locked = new Error('SQLITE_BUSY');
isTransientSqliteLockError(new AggregateError([locked, locked])); // 修正前 false前者は 修正は 残る指摘(任意・本 PR ではブロッカーではない)
marker 書き込み順序、delete 失敗時も close を実行する後始末契約、非一時的エラーの即時伝播はいずれも維持されています。 #104 との関係
|
npm beta packages publishedCI passed for the merge commit npm install @rdlabo/ionic-angular-kit@22.0.2-beta.pr107.shabca274cf9d55 @rdlabo/ionic-angular-photo-editor@22.0.2-beta.pr107.shabca274cf9d55 @rdlabo/ionic-angular-scroll-header@22.0.2-beta.pr107.shabca274cf9d55 @rdlabo/ngx-cdk-scroll-strategies@22.0.2-beta.pr107.shabca274cf9d55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Review cycles
Fixes FOODLABEL-APP-CR