fix(demo): align ESLint peers with Ionic 8 and 9 - #44
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Playwright test results
Details
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-44/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ionic 9 demo deployment fails with ERESOLVE because the demo installs ESLint plugin v21, whose optional Ionic Core peer only accepts v8.
Align the default demo dependency graph with Ionic 9 and ESLint plugin v22. Switch the plugin together with Ionic when running the Ionic 8 deploy, E2E, and screenshot-update paths. Adapt the renamed standalone-import lint rule and exempt only the existing version-compatibility entry points.
The theme's public dependencies and Ionic 8/9 support are unchanged. No peer-dependency bypass is used.
Validation: Ionic 9 dependency installation, demo lint, 36 unit tests, and production build passed locally. Ionic 8 dependency installation, demo lint, and production build also passed. Root theme builds passed with both Ionic versions, and repository formatting passed.