Skip to content

Allow rotation to pass through#387

Closed
jbborre wants to merge 2 commits into
react-grid-layout:masterfrom
jbborre:master
Closed

Allow rotation to pass through#387
jbborre wants to merge 2 commits into
react-grid-layout:masterfrom
jbborre:master

Conversation

@jbborre

@jbborre jbborre commented Feb 13, 2019

Copy link
Copy Markdown

Updated the transform css and svg attribute to allow for rotation to be passed through.

@STRML

STRML commented Apr 11, 2020

Copy link
Copy Markdown
Collaborator

Not sure I understand the use case here. I recommend double-wrapping your component instead of requiring a core lib modification.

@STRML STRML mentioned this pull request Apr 11, 2020
@cjshearer

Copy link
Copy Markdown

Not sure I understand the use case here. I recommend double-wrapping your component instead of requiring a core lib modification.

Simple. Double wrapping breaks any <Draggable attempting to use bounds="parent".

@STRML

STRML commented Jun 15, 2021

Copy link
Copy Markdown
Collaborator

You can use a querySelector for bounds as well.

That said, I can't accept this with all the dist changes.

@OT-mliang

Copy link
Copy Markdown

Double wrapping also drags in relation to the rotated parent

@STRML

STRML commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

Closing this PR as stale. This PR has been open since 2019 without being merged. See PR #751 for a more recent implementation of rotation support. Thank you for the contribution!

@STRML STRML closed this Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants