build: bump body-parser dependency to resolve qs security issue#2752
Closed
azizbecha wants to merge 4 commits intoreact-native-community:mainfrom
Closed
build: bump body-parser dependency to resolve qs security issue#2752azizbecha wants to merge 4 commits intoreact-native-community:mainfrom
azizbecha wants to merge 4 commits intoreact-native-community:mainfrom
Conversation
Member
|
Please rebase and we can merge it. The only breaking change was bumping node to 18, so should be fine |
…ive-community#2758) * Initial plan * fix: use strict-url-sanitise to prevent RCE vulnerability (CVE-2025-11953) Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> * refactor: cache sanitizeUrl to improve performance Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> * simplify: use "Invalid URL" error message, remove strict-url-sanitise mock Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> * style: replace it() with test() in openURLMiddleware tests Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> * refactor: use ordinary import for strict-url-sanitise Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> * refactor: remove named export of openURLMiddleware, test default export Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> * test: add CVE-2025-11953 test cases for Windows pipe and command exfiltration Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> * test: add CVE-2025-11953 comment above second test case Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> * fixup tests to not hang when fail --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: huntie <2547783+huntie@users.noreply.github.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
azizbecha
force-pushed
the
fix/bump-body-parser-qs-security
branch
from
67b5519 to
08ea42e
Compare
Collaborator
Author
|
@thymikee Done! |
Member
|
Unit test are failing now, mind checking? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a reported security issue related to the qs dependency used by
cli-server-api.The CLI currently pulls in
qs@6.13.0viabody-parser@1.20.3. Versions ofqs≤6.14.0are affected by a known DoS vulnerability related to arrayLimit handling in bracket notation.Following the maintainer’s guidance in #2750, this change bumps body-parser to a version that depends on a patched
qsrelease, resolving the vulnerability without introducing functional changes to the CLI itself.Closes #2750.
Test Plan
No runtime behavior changes are expected, as this is a dependency-only update.
Checklist
react-nativecheckout (instructions).