Skip to content

Fix OS command injection in openBrowser (CVE-2026-14802)#17274

Open
vimalviswan wants to merge 1 commit into
react:mainfrom
vimalviswan:fix/openbrowser-command-injection
Open

Fix OS command injection in openBrowser (CVE-2026-14802)#17274
vimalviswan wants to merge 1 commit into
react:mainfrom
vimalviswan:fix/openbrowser-command-injection

Conversation

@vimalviswan

Copy link
Copy Markdown

Summary

Root cause

On Darwin, startBrowserProcess built an osascript command string and passed it through execSync. encodeURI(url) does not escape shell-significant characters ($, (, )), so a crafted URL such as http://localhost/$(touch$IFS/tmp/...) could execute arbitrary commands when Chrome was already running.

Fix

execFileSync(
  'osascript',
  ['openChrome.applescript', encodeURI(url), chromiumBrowser],
  { cwd: __dirname, stdio: 'ignore' }
);

Test plan

  • npm test -- --testPathPattern=openBrowser in packages/react-dev-utils (4 passing)
  • On macOS with Chrome running, confirm openBrowser('http://localhost:3000') still reuses an existing tab
  • Confirm a URL containing $(...) / $IFS does not create side effects on disk when opened via the AppleScript path

Closes #17269

Use execFileSync so URLs with shell metacharacters cannot be
interpreted when launching Chrome via AppleScript (CVE-2026-14802).

Co-authored-by: Cursor <cursoragent@cursor.com>
@meta-cla

meta-cla Bot commented Jul 24, 2026

Copy link
Copy Markdown

Hi @vimalviswan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OS Command Injection in openBrowser.js

1 participant