Fix asset root containment check#1748
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
Metro’s asset fallback guard used a string prefix check in
pathBelongsToRoots()and could incorrectly treat sibling-prefix paths as inside allowed roots (for example,/app2/...matching/app). This can allow non-root assets to pass containment checks when file-map membership is unknown.What changed
pathBelongsToRoots()inpackages/metro/src/Assets.jsto usepath.resolve()+path.relative()containment checks.isPathInsideRoot(...)helper for explicit, readable root containment logic and to reject:/app2vs/app)packages/metro/src/__tests__/Assets-test.jsfor:path.join()/path.resolve()calls where updated tests were introduced.Why this is safe
Only containment acceptance criteria changed; legitimate in-root paths remain valid while prefix-only matches are removed. This narrows access to expected roots and avoids stale or incorrect fallback reads.
Validation
yarn test packages/metro/src/__tests__/Assets-test.js