Include transform dependency modules in Metro worker cache key#1749
Open
fallintoplace wants to merge 2 commits into
Open
Include transform dependency modules in Metro worker cache key#1749fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
The Metro transform cache key did not include all transform-affecting internal workers, so changes to those modules could avoid cache invalidation.
What changed
filesKeylist inpackages/metro-transform-worker/src/index.js(collectDependencies,generateImportNames,JsFileWrapping,importLocationsPlugin) and added an explicit inline policy comment describing expected cache-key coverage.packages/metro-transform-worker/src/__tests__/index-test.js:toHaveBeenCalledWith(expect.arrayContaining(...))and removed unrelated mock-return-value wiring.Why this is safer
The cache key now reflects key internal transform inputs that can affect emitted output and avoids stale transform-cache entries when those internals evolve.
Validation
yarn test packages/metro-transform-worker/src/__tests__/index-test.js