Conversation
Original commit changeset: 3d0f468 This is an AI slop API I think I accidentally left published when I left Meta, and was landed alongside some other work. There's no need for a helper like this to exist in core and even if there were, this isn't the right shape. - "Static file" isn't really a thing - the crawler API is meant to allow for virtual file systems, they're not necessarily static. - Needlessly takes its input in a different shape to the output and converts (essentially most of the function) - expensive on large file sets. - `Reflect.set` to avoid a Flow error.. .*what*. This has never been released, so we can still remove it as non-breaking. Changelog: Internal Test plan: CI
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit changeset: 3d0f468
This is an AI slop API I think I accidentally left published when I left Meta, and was landed alongside some other work.
There's no need for a helper like this to exist in core and even if there were, this isn't the right shape.
Reflect.setto avoid a Flow error.. .what.This has never been released, so we can still remove it as non-breaking.
Changelog: Internal
Test plan:
CI