Skip to content

fix: Make EventTarget methods enumerable #57247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
retyui wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

fix: Make EventTarget methods enumerable #57247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react-native/src/private/webapis/dom/events/EventTarget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,13 @@ export default class EventTarget {
}
}

// $FlowExpectedError[cannot-write]
Object.defineProperties(EventTarget.prototype, {
addEventListener: {enumerable: true},
removeEventListener: {enumerable: true},
dispatchEvent: {enumerable: true},
});

setPlatformObject(EventTarget);

function validateCallback(callback: EventListener, methodName: string): void {
Expand Down
13 changes: 13 additions & 0 deletions packages/react-native/src/private/webapis/dom/events/__tests__/EventTarget-itest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,19 @@ function createListener(
}

describe('EventTarget', () => {
it('should have 3 enumerable methods', () => {
const methods = new Set([
'addEventListener',
'removeEventListener',
'dispatchEvent',
]);
for (const key in new EventTarget()) {
expect(methods.has(key)).toBe(true);
methods.delete(key);
}
expect(methods.size).toBe(0);
});

describe('addEventListener', () => {
it('should throw an error if event or callback are NOT passed', () => {
const eventTarget = new EventTarget();
Expand Down
Loading