Cover 'react/performance' subtree with C++ stable API guards#57320
Open
coado wants to merge 4 commits into
Open
Cover 'react/performance' subtree with C++ stable API guards#57320coado wants to merge 4 commits into
coado wants to merge 4 commits into
Conversation
Differential Revision: D108422344
Summary: Codemod for simplifying making changes to the targets. This should not be commited. Differential Revision: D109418112
Differential Revision: D109316840
Summary: Adds private guards to `react/performance/timeline:timeline` and `react/performance/cdpmetrics:cdpmetrics` headers preventing from inclusions when `RN_STABLE_API` is turned on. Changelog: [Internal] Differential Revision: D109558177
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109558177. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds private guards to
react/performance/timeline:timelineandreact/performance/cdpmetrics:cdpmetricsheaders preventing from inclusions whenRN_STABLE_APIis turned on.Changelog:
[Internal]
Differential Revision: D109558177