Skip to content

Add DynamicAccessedMembers attributes to BindingListEx methods #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-lerch wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −5
Open

Add DynamicAccessedMembers attributes to BindingListEx methods #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/DynamicData/Binding/BindingListEx.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System.Collections.ObjectModel;
using System.ComponentModel;
using System.Diagnostics.CodeAnalysis;
using System.Reactive;
using System.Reactive.Linq;

Expand All @@ -30,7 +31,7 @@ public static IObservable<EventPattern<ListChangedEventArgs>> ObserveCollectionC
/// <param name="source">The source.</param>
/// <returns>An observable which emits change set values.</returns>
/// <exception cref="ArgumentNullException">source.</exception>
public static IObservable<IChangeSet<T>> ToObservableChangeSet<T>(this BindingList<T> source)
public static IObservable<IChangeSet<T>> ToObservableChangeSet<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T>(this BindingList<T> source)
where T : notnull
{
source.ThrowArgumentNullExceptionIfNull(nameof(source));
Expand All @@ -50,7 +51,7 @@ public static IObservable<IChangeSet<T>> ToObservableChangeSet<T>(this BindingLi
/// <exception cref="ArgumentNullException">source
/// or
/// keySelector.</exception>
public static IObservable<IChangeSet<TObject, TKey>> ToObservableChangeSet<TObject, TKey>(this BindingList<TObject> source, Func<TObject, TKey> keySelector)
public static IObservable<IChangeSet<TObject, TKey>> ToObservableChangeSet<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] TObject, TKey>(this BindingList<TObject> source, Func<TObject, TKey> keySelector)
where TObject : notnull
where TKey : notnull
{
Expand Down Expand Up @@ -132,7 +133,7 @@ public static IObservable<IChangeSet<T>> ToObservableChangeSet<TCollection, T>(t
});
}

internal static void Clone<T>(this BindingList<T> source, IEnumerable<Change<T>> changes)
internal static void Clone<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T>(this BindingList<T> source, IEnumerable<Change<T>> changes)
where T : notnull
{
// ** Copied from ListEx for binding list specific changes
Expand All @@ -145,7 +146,7 @@ internal static void Clone<T>(this BindingList<T> source, IEnumerable<Change<T>>
}
}

private static void Clone<T>(this BindingList<T> source, Change<T> item, IEqualityComparer<T> equalityComparer)
private static void Clone<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T>(this BindingList<T> source, Change<T> item, IEqualityComparer<T> equalityComparer)
where T : notnull
{
switch (item.Reason)
Expand Down
3 changes: 2 additions & 1 deletion src/DynamicData/DynamicData.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>netstandard2.0;net462;net8.0;net6.0;net7.0;net8.0;net9.0;net10.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462;net6.0;net7.0;net8.0;net9.0;net10.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<IsAotCompatible>true</IsAotCompatible>
<IsPackable>true</IsPackable>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>
Expand Down
Loading