Conversation
|
someone please pay attention to this PR |
| }); | ||
| }); | ||
|
|
||
| it('should use `React.findDOMNode` when `nodeRef` is not provided', () => { |
There was a problem hiding this comment.
better to skip it conditionally based on React version
|
@jquense I'd say we should update our build settings , outdated dependencies and documentation system before updating React version. |
|
you wanna do it? |
|
Yeah, I'll do it when I have time, but it would be helpful someone takes that. The documentation also depends on PropTypes, which was removed in v19, so it would be better to update the documentation as well. https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-apis |
|
it would be so helpful if this MR would be included soon🙏 |
|
@sergioviniciuss |
|
@koba04 I'm seeing an issue when using the Transition component on React v19: |
You need to add a ref and it'll work like this: This will make it not crash but it will still fail on typing through eslint, so you might want to disable it for that. |
This only updates CI settings and tests.
react-transition-groupseems to work with React 19 without any updates