Skip to content

⚡ Parallelize file copy and delete operations in HarmonyOS DownloadTask #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunnylqm wants to merge 1 commit into from
+21 −17
Closed

⚡ Parallelize file copy and delete operations in HarmonyOS DownloadTask #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions harmony/pushy/src/main/ets/DownloadTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,23 +350,27 @@ export class DownloadTask {
);

const { copies, deletes } = obj;
for (const [to, from] of Object.entries(copies)) {
await fileIo
.copyFile(
`${params.originDirectory}/${from}`,
`${params.unzipDirectory}/${to}`,
)
.catch(error => {
console.error('copy error:', error);
});
}
for (const fileToDelete of Object.keys(deletes)) {
await fileIo
.unlink(`${params.unzipDirectory}/${fileToDelete}`)
.catch(error => {
console.error('delete error:', error);
});
}
await Promise.all(
Object.entries(copies as Record<string, string>).map(([to, from]) =>
fileIo
.copyFile(
`${params.originDirectory}/${from}`,
`${params.unzipDirectory}/${to}`,
)
.catch(error => {
console.error('copy error:', error);
}),
),
);
await Promise.all(
Object.keys(deletes as Record<string, string>).map(fileToDelete =>
fileIo
.unlink(`${params.unzipDirectory}/${fileToDelete}`)
.catch(error => {
console.error('delete error:', error);
}),
),
);
continue;
}
if (fn === 'bundle.harmony.js.patch') {
Expand Down