Dark Mode style: apply dark mode overrides to the conduit theme file#344
Closed
puurva wants to merge 1 commit intorealworld-apps:mainfrom
Closed
Dark Mode style: apply dark mode overrides to the conduit theme file#344puurva wants to merge 1 commit intorealworld-apps:mainfrom
puurva wants to merge 1 commit intorealworld-apps:mainfrom
Conversation
Contributor
|
Can't merge as-is:
Dark theme is a good idea but should then become part of the spec. If you are interested, you can try modifying the whole CSS file depending on a single class to toggle dark mode, and then the frontend implementations will be adapted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.