Add posterHelper for null posters#2404
Closed
Kraptor123 wants to merge 2 commits intorecloudstream:masterfrom
Closed
Add posterHelper for null posters#2404Kraptor123 wants to merge 2 commits intorecloudstream:masterfrom
Kraptor123 wants to merge 2 commits intorecloudstream:masterfrom
Conversation
fire-light42
reviewed
Jan 9, 2026
Collaborator
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
It is unnecessary to rely on an external service, especially concerning UI. This adds uncalled-for network calls, for something that should be done in the view. Interesting service, but the premise of the pull request can not be accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate placeholder poster URLs for missing posters (custom text/size/color/font). Uses placehold.co for image generation.
Example usage:
Result: