[CodeQuality] Skip AssertIssetToSpecificMethodRector on ArrayAccess objects#692
Merged
Conversation
…bjects isset($obj[$key]) on an ArrayAccess object is not equivalent to assertArrayHasKey($key, $obj): the key may be any type (assertArrayHasKey() requires int|string) and offsetExists() semantics can differ from array_key_exists(). Converting it produced code that throws for non-scalar keys. Skip the rule when the subject is an ArrayAccess object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
AssertIssetToSpecificMethodRectorturnsisset($x[$key])inside an assert intoassertArrayHasKey($key, $x). That is correct for native arrays, but not forArrayAccessobjects:assertArrayHasKey()requires the key to beint|string;isset($obj[$key])(i.e.
offsetExists()) accepts any key type.offsetExists()semantics can differ fromarray_key_exists().Found in webonyx/graphql-php. Its
MixedStoreTestexercises anArrayAccessstore with keys of every type(
null,bool,float, array, object). The conversion produces code thatthrows for those keys, which is why
rector.phpskips the rule on that file:Fix
Skip the rule when the array-dim subject is an
ArrayAccessobject. Nativearrays (the intended target) are unaffected. Added
skip_array_access_object.php.incArrayAccesssource stub.