[CodeQuality] Skip existing imported or short @ see annotation in AddSeeTestAnnotationRector - #779
Merged
Conversation
…SeeTestAnnotationRector
Member
Author
|
Fixed 🎉 /cc @Brainshaker95 |
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
Thanks |
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to @see resolution, and the added fixtures cover the newly supported cases to prevent regressions.
Pull request overview
Updates AddSeeTestAnnotationRector to correctly detect already-present @see tags when they reference a class using a short name (either imported via use or resolved from the current namespace), preventing duplicate @see additions and aligning behavior with rectorphp/rector#9875.
Changes:
- Inject
ClassAnnotationMatcherand use it to resolve@seetag values to fully qualified class names before checking existence viaReflectionProvider. - Add fixtures covering “short
@seein same namespace” and “imported short @see” cases. - Add a source class used by the imported-
@seefixture.
File summaries
| File | Description |
|---|---|
| rules/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector.php | Resolves short @see values to FQCNs before deciding to skip adding an annotation. |
| rules-tests/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector/Source/SkipExistingImportedSeeTest.php | Adds a resolvable class for the imported-@see fixture scenario. |
| rules-tests/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector/Fixture/skip_existing_short_see.php.inc | Fixture ensuring a short @see in the same namespace prevents adding another @see. |
| rules-tests/CodeQuality/Rector/Class_/AddSeeTestAnnotationRector/Fixture/skip_existing_imported_see.php.inc | Fixture ensuring an imported short @see prevents adding another @see. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9875