Skip to content

[Renaming] Handle namespaced annotation on RenameClassRector#7333

Merged
samsonasik merged 6 commits into
mainfrom
handle-namespaced-annotation
Sep 26, 2025
Merged

[Renaming] Handle namespaced annotation on RenameClassRector#7333
samsonasik merged 6 commits into
mainfrom
handle-namespaced-annotation

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Closes #7330

@samsonasik

Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @simonschaufi

@samsonasik

samsonasik commented Sep 26, 2025

Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

For note: @simonschaufi this patch ensure we got same NonExistingObjectType without changing the Identifier name when there is no change. To ensure it always works on your use case,it is always recommended to add use TYPO3 to use statement, so you got correct ObjectType.

@samsonasik samsonasik merged commit b6edd89 into main Sep 26, 2025
50 checks passed
@samsonasik samsonasik deleted the handle-namespaced-annotation branch September 26, 2025 10:07
@simonschaufi

Copy link
Copy Markdown
Contributor

Wow, you really impressed me that you could fix it so quickly. I guess you had to debug quite a lot to understand what is going on here. Thank you very much!

I have one wish: Please don't close the next issue so quickly but give me some time to respond.

@samsonasik

Copy link
Copy Markdown
Member Author

Yes, that was a nightmare 😅

Well, I can't promise on that 😎

@simonschaufi

simonschaufi commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

I'm proud of you!

Do you have a release cycle or when can I expect the next release?

@samsonasik

Copy link
Copy Markdown
Member Author

It usually 2 weeks to 1 month cycle, you can try dev-main and verify if there is regression

@github-actions

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants