Bump to PHPStan ^2.1.40 and utilize ClassConstantReflection->isFinalByKeyword()#7911
Merged
TomasVotruba merged 4 commits intomainfrom Feb 23, 2026
Merged
Bump to PHPStan ^2.1.40 and utilize ClassConstantReflection->isFinalByKeyword()#7911TomasVotruba merged 4 commits intomainfrom
TomasVotruba merged 4 commits intomainfrom
Conversation
Member
Author
|
@TomasVotruba ready 👍 |
samsonasik
force-pushed
the
bump-phpstan-2140
branch
from
1d2e115 to
1d4e151
Compare
Member
Author
|
Rebased and added fixture to skip docblock based |
Member
Author
|
@TomasVotruba ready to merge 👍 |
Member
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My PR to PHPStan was merged yesteday:
for add
ClassConstantReflection::isFinalByKeyword()method to detect native final, over docblock based final.The PHPStan 2.1.40 released today with include the new feature:
This PR bump PHPStan to ^2.1.40 and use the new method, replace the old tweak to get the native final which need to verify on php version check first and native reflection resolving, now, it covered on phpstan.