[code-quality] Add AttributeNamedArgsRector#8079
Merged
TomasVotruba merged 2 commits intoJun 27, 2026
Merged
Conversation
Convert positional arguments on configured attributes into named arguments, taking the names from the attribute constructor signature. Configurable per attribute class via the AttributeNamedArgs value object, with an optional firstNamedPosition threshold to leave leading arguments positional. Skips already-named arguments and bails out when an argument maps to a variadic or missing parameter to avoid producing invalid PHP.
| * @param int $firstNamedPosition first positional index to name (0 = name all arguments) | ||
| */ | ||
| public function __construct( | ||
| private string $attributeClass, |
Member
There was a problem hiding this comment.
Could you add simple class-name validation here?
Ref \Rector\Validation\RectorAssert::className()
Member
|
Very nice rule! 👏 We actually have PHPStan rule enforcing this, but still do it manually lol |
Member
|
I wasn't sure what is does untill I checked examples. Could you update name to |
| } | ||
| CODE_SAMPLE | ||
| , | ||
| [new AttributeNamedArgs('Some\Attribute\SomeAttribute')] |
Member
There was a problem hiding this comment.
Also, this rule should handle all or none. It doesn't make sense to explictly list the attributes one by one (there is just ~30 in Symfony, maybe same in Laravel).
…configurable (name all attributes), move to named-args set
Member
|
Pushed an update addressing the review:
Tests reworked accordingly (7 fixtures, all green). |
Member
|
I've updated PR and go for merge 👍 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert positional arguments on configured attributes into named arguments, taking the names from the attribute constructor signature. Configurable per attribute class via the AttributeNamedArgs value object, with an optional firstNamedPosition threshold to leave leading arguments positional. Skips already-named arguments and bails out when an argument maps to a variadic or missing parameter to avoid producing invalid PHP.