[CodeQuality] Keep parentheses around Ternary operand in SimplifyConditionsRector#8122
Merged
Merged
Conversation
…itionsRector Fixes #8121 - inverting a binary op whose operand is a ternary dropped the parentheses, changing evaluation due to lower ternary precedence.
Member
Author
|
Thank you for reporting 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8121.
SimplifyConditionsRectorinverts a binary op when wrapped in a boolean not, e.g.! (1 < X)→1 >= X. When the operandXis a ternary, the format-preserving printer dropped the parentheses. Since the ternary has lower precedence than>=, the result changed meaning:Now
createInversedBooleanOp()setsWRAPPED_IN_PARENTHESESon ternary operands, matching the existing precedent inUseIdenticalOverEqualWithSameTypeRector, producing the correct:Bug report and failing fixture by @j-dobr in #8121.
Co-authored-by: Jan Dobrovodsky jan.dobrovodsky@promedcs.com