Skip to content

Make edit mode entity ellipses more detailed - #989

Merged
qreeves merged 1 commit into
redeclipse:masterfrom
Calinou:increase-edit-ellipse-detail
Oct 7, 2026
Merged

qreeves merged 1 commit into
redeclipse:masterfrom
Calinou:increase-edit-ellipse-detail

Conversation

@Calinou

@Calinou Calinou commented Jan 2, 2020 •

Copy link
Copy Markdown
Member

This makes edit mode ellipses look less "angular".

Preview

Hovered entity ellipse

@qreeves qreeves left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

{
// The number of polygon sides to use.
// The polygon rendering breaks if this is set too high.
const int detail = 40;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would rather this be a variable. There are legitimate performance reasons to not want ellipses to be highly detailed as there can be large amounts of them if you select a lot of entities.

qreeves added a commit that referenced this pull request Oct 7, 2026
Make edit mode entity ellipses more detailed
@qreeves
qreeves merged commit 29abf35 into redeclipse:master Oct 7, 2026
@qreeves

qreeves commented Oct 7, 2026

Copy link
Copy Markdown
Member

Thanks for this, and sorry for the long wait! This is now merged into master (b4a7bcc), with two follow-up changes:

  • The side count is a setting. particleellipsesides (3 to 360) controls how many sides ellipses are drawn with. It defaults to 15, the previous count, because selecting many entities in edit mode draws many ellipses and more sides cost performance. Mappers who want smoother outlines can raise it, e.g. to the 40 you proposed.
  • Ellipses close for any side count. The angle step was 360/sides in integer division, so counts that don't divide 360 left a gap (that was the "breaks if set too high" behaviour). Each angle is now i*360/sides, which always ends at 360.

@Calinou
Calinou deleted the increase-edit-ellipse-detail branch October 7, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants