[release-1.9] fix: sort map keys to prevent non-deterministic pod spec diffs [RHDHBUGS-3084]#2788
Conversation
…UGS-3084] (redhat-developer#2785) * fix: sort map keys to prevent non-deterministic pod spec diffs Go map iteration order is randomized, so maps.Keys() produced different key orderings on each reconciliation. This caused VolumeMounts and --config args to shuffle, making the controller detect a spec change and restart pods in a loop. Signed-off-by: Armel Soro <armel@rm3l.org> * update docs --------- Signed-off-by: Armel Soro <armel@rm3l.org>
rm3l
changed the title
|
Member
Author
|
Merging as #2785 was already approved. This one is just a backport PR. |
rm3l
deleted the
RHDHBUGS-3084--operator-reconciliation-loop-caused-by-non-deterministic-go-map-iteration-order-in-configmap-key-handling-pod-restarts-when-using-statefulset-workload--backport-1.9
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backporting #2785 to 1.9
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer