Update language client to 10.1.0 - #4476
Merged
datho7561 merged 1 commit intoAug 25, 2026
Merged
Conversation
datho7561
changed the title
datho7561
force-pushed
the
wip-update-languageclient
branch
5 times, most recently
from
August 21, 2026 16:25
ab50010 to
2d2a745
Compare
datho7561
changed the title
datho7561
force-pushed
the
wip-update-languageclient
branch
from
August 21, 2026 16:26
2d2a745 to
f32b381
Compare
datho7561
commented
Aug 21, 2026
- Update to TypeScript 6 (TODO: split off into a different PR)
- Update to `vscode-langaugeclient@^10.1.0`
- Adjust to changes to language server logging API
- VS Code now provides client-side log filtering based on a configured
log level. This interacts in a slightly annoying way with our own
server side log filtering, but ultimately both are helpful to have,
since disabling logging on the client still means the server is
sending trace level messages, which may be annoying
Required to get `workspace/textDocumentContent` working,
see eclipse-jdtls/eclipse.jdt.ls#3855
Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
wip-update-languageclient
branch
from
August 21, 2026 16:29
f32b381 to
04d797a
Compare
datho7561
marked this pull request as ready for review
August 21, 2026 17:27
Contributor
Author
|
@MeherSru if you have time, do you mind testing this? Specifically:
|
Contributor
|
regular features (errors, hover, go to definition) work fine, and jdt:// hover links work correctly too, clicking a JDK class link in hover Javadoc opens the decompiled source properly. |
Contributor
Author
|
Thanks for reviewing, Meher! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vscode-langaugeclient@^10.1.0Requires #4487mergedRequired to get
workspace/textDocumentContentworking, see eclipse-jdtls/eclipse.jdt.ls#3855