Skip to content

Smoke test all binaries using matrix build#1115

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:1114-smoke-tests-matrix
Apr 23, 2026
Merged

Smoke test all binaries using matrix build#1115
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:1114-smoke-tests-matrix

Conversation

@datho7561
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 commented Nov 10, 2025 •
edited
Loading

This lets us smoke test the binaries for every platform instead of just linux x86_64.

The builds are run in parallel, which looks a bit messy in the output but hopefully will mean it takes around 10 minutes to get all the results.

I wrote the windows part so that it can be expanded to include arm64 in the future.

Also fixes a bug preventing the linux arm64 binary from being used.

@datho7561 datho7561 force-pushed the 1114-smoke-tests-matrix branch 2 times, most recently from 3747ab9 to ab147a1 Compare November 10, 2025 17:55
@datho7561
Copy link
Copy Markdown
Contributor Author

datho7561 commented Nov 10, 2025

(Draft because it's not working and I still need to add windows)

@datho7561 datho7561 force-pushed the 1114-smoke-tests-matrix branch 3 times, most recently from b8ae47b to 59431a3 Compare November 10, 2025 18:28
@datho7561
Copy link
Copy Markdown
Contributor Author

datho7561 commented Nov 10, 2025

Not pleased with having to wait for all the binaries to build in order to run the tests with them; I'll have to look into if I can improve that

@datho7561 datho7561 force-pushed the 1114-smoke-tests-matrix branch 6 times, most recently from 9beaf9e to f0c9738 Compare November 10, 2025 20:57
@datho7561
Copy link
Copy Markdown
Contributor Author

datho7561 commented Nov 10, 2025 •
edited
Loading

I'm checking to see if the binary is actually broken on apple arm64..... nope, I named the binary wrong in the build process. Hopefully that's fixed; after the tests pass, I'll clean up the commits and mark this as ready for review.

@datho7561 datho7561 force-pushed the 1114-smoke-tests-matrix branch 9 times, most recently from 690902c to 44b55ce Compare November 11, 2025 19:27
@datho7561 datho7561 changed the title [WIP] matrix build for smoke tests Smoke test all binaries using matrix build Nov 11, 2025
@datho7561 datho7561 marked this pull request as ready for review November 11, 2025 19:28
@datho7561
Copy link
Copy Markdown
Contributor Author

datho7561 commented Nov 11, 2025

Ugh seems like I'll need to adjust the timeouts for Windows for it to be consistent :(

@datho7561 datho7561 force-pushed the 1114-smoke-tests-matrix branch from 44b55ce to 94c43b3 Compare November 11, 2025 19:48
@datho7561
Copy link
Copy Markdown
Contributor Author

datho7561 commented Nov 11, 2025

going to push a few blank amends to check the consistency of the tests passing.

@datho7561 datho7561 force-pushed the 1114-smoke-tests-matrix branch 2 times, most recently from 812cc85 to 5705851 Compare November 11, 2025 21:20
@datho7561 datho7561 requested a review from fbricon November 11, 2025 21:21
vidhanio
vidhanio approved these changes Nov 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vidhanio vidhanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datho7561 datho7561 force-pushed the 1114-smoke-tests-matrix branch from 5705851 to 9b6696b Compare April 23, 2026 15:34
@datho7561
Copy link
Copy Markdown
Contributor Author

datho7561 commented Apr 23, 2026

Fixes #1145

@datho7561
Smoke test all binaries using matrix build
f7ce09f 
This lets us smoke test the binaries for every platform instead of just linux
x86_64.
The builds are run in parallel, which looks a bit messy in the output
but hopefully will mean it takes around 10 minutes to get all the
results.
I wrote the windows part so that it can be expanded to include arm64 in
the future.

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the 1114-smoke-tests-matrix branch from 9b6696b to f7ce09f Compare April 23, 2026 15:49
rgrunber
rgrunber approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rgrunber rgrunber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Just curious, was the linux-arm64 support wrongly using lemminx-linux-x86_64 ?

Update: Nevermind, you explained here #930 (comment) .

@datho7561 datho7561 merged commit 4a397b3 into redhat-developer:main Apr 23, 2026
11 checks passed
@datho7561 datho7561 deleted the 1114-smoke-tests-matrix branch April 23, 2026 16:08
@datho7561 datho7561 mentioned this pull request Apr 23, 2026
Closed
@datho7561 datho7561 added this to the 0.30.0 milestone Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgrunber rgrunber rgrunber approved these changes

@fbricon fbricon Awaiting requested review from fbricon

+1 more reviewer

@vidhanio vidhanio vidhanio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.29.2

Development

Successfully merging this pull request may close these issues.

3 participants

@datho7561 @rgrunber @vidhanio