Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes client error handling by removing redundant raise statements after _handle_http_error calls. The _handle_http_error method already raises appropriate exceptions, so the additional raise statements were causing the original HTTPStatusError to be re-raised instead of the proper custom exceptions, breaking error handling flow.
- Removes redundant
raisestatements from all HTTP error handling blocks in the client - Adds comprehensive test coverage for the
get_or_create_working_memorymethod's 404 handling - Updates version from 0.12.2 to 0.12.3
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| agent-memory-client/agent_memory_client/client.py | Removes redundant raise statements from HTTP error handling blocks across all API methods |
| agent-memory-client/tests/test_client.py | Adds test to verify proper 404 error handling in get_or_create_working_memory method |
| agent-memory-client/agent_memory_client/init.py | Updates package version to 0.12.3 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The _handle_http_error method raises exceptions but the code was re-raising the original HTTPStatusError, preventing get_or_create_working_memory from catching MemoryNotFoundError and creating new sessions. Changes: - Remove redundant raise statements after _handle_http_error calls - Change _handle_http_error return type to NoReturn for mypy - Add test to verify 404 handling works correctly - Bump version to 0.12.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't re-raise the original error because upstream, we expect a custom error, not the original.