fix: stabilize test_text_query_word_weights with structural assertions

[thakoreh]

Summary

Fixes the flaky test_text_query_word_weights test (related to #497).

Replaces the exact-string assertion (sensitive to non-deterministic token ordering in older Python dicts) with structural component checks:

• Description clause is properly delimited with (...)
• Weighted terms (alpha=>{$weight:2}, delta=>{$weight:0.555}) appear inside the clause
• alpha count matches input frequency (2 occurrences)
• All unweighted terms are present
• Post-query modifiers (SCORER, WITHSCORES, DIALECT, LIMIT) follow in order

This is resistant to token ordering while still catching regressions in query structure. Addresses review feedback on #524.

Testing

• Unit tests pass (verified locally without Docker)

---

Note

Low Risk
Low risk: changes are limited to a unit test, replacing a brittle exact-string assertion with order-insensitive structural checks to reduce flakiness.

Overview
Stabilizes test_text_query_word_weights by removing the skipped/brittle exact query-string comparison and replacing it with structural assertions that tolerate non-deterministic token ordering.

The test now validates the @description:(...) clause contents (including weighted terms and repeated weighted alpha) and ensures the expected post-query modifiers (SCORER, WITHSCORES, DIALECT, LIMIT) appear after the clause in the correct sequence.

^{Written by Cursor Bugbot for commit 9680523. This will update automatically on new commits. Configure here.}

[Copilot]

Pull request overview

This PR re-enables and stabilizes the previously flaky test_text_query_word_weights by replacing an exact full-string comparison with structural assertions that are intended to be insensitive to token ordering while still validating query shape.

Changes:

• Removed the @pytest.mark.skip that was disabling the flaky test.
• Replaced the single exact-string assertion with component-based checks over the generated query string.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The comment about token ordering being non-deterministic is likely misleading here: TextQuery._tokenize_and_escape_query() preserves the input token order and only does in-place substitutions for weighted tokens. If the goal is to avoid brittleness, consider rewording this to the actual nondeterminism/flakiness source (or just say the test avoids exact full-string matching).

Suggested change

	# Check query components with structural guarantees,
	# not exact token ordering (which is non-deterministic).
	# Check query components with structural guarantees rather than relying
	# on exact full-string or token-order matching, to avoid brittle tests.

[Copilot]

desc_clause.count(alpha_weighted) and the subsequent find("alpha") loop rely on substring matching, which can behave unexpectedly if token escaping changes or a different token contains alpha as a substring. Since tokens are joined with " | ", consider splitting desc_clause into tokens (strip whitespace) and asserting exact token equality + frequency via a list/Counter.

[Copilot]

assert term in desc_clause checks substrings, not whole tokens, so it may pass even if the tokenization/output changes in a way that shouldn’t be acceptable (or fail for escaped tokens). Consider tokenizing desc_clause (split on | and strip) and asserting the expected token set is present.

Suggested change

	# Unweighted terms are present
	for term in ["query", "string", "bravo", "tango"]:
	assert term in desc_clause
	# Unweighted terms are present as standalone tokens within the clause
	desc_tokens = {token.strip() for token in desc_clause.split("|") if token.strip()}
	for term in ["query", "string", "bravo", "tango"]:
	assert term in desc_tokens

[vishal-bala]

Hi @thakoreh, thanks for the contribution. Can you take a look at the automated review comments?