Merged
Conversation
Contributor
Greptile SummaryRemoves Typesense search indexing from all CI/CD deployment workflows (dev, staging, production) and deletes the standalone
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Deploy Workflow Triggered] --> B[Checkout & Install]
B --> C{Before This PR}
C -->|Yes| D[Install Typesense deps]
D --> E[Run typesense_indexer.py]
E --> F[Run synonym_indexer.py]
F --> G[Deploy to Reflex Cloud]
C -->|After This PR| G
G --> H[Site Live]
H --> I[User Searches Docs]
I --> J[typesense.py queries Typesense]
J --> K{Index populated?}
K -->|Before PR: Yes| L[Search Results Returned]
K -->|After PR: Stale/Empty| M[⚠️ Potentially Broken Search]
style D fill:#f88,stroke:#333
style E fill:#f88,stroke:#333
style F fill:#f88,stroke:#333
style M fill:#ff0,stroke:#333
Last reviewed commit: 23aed10 |
Comment on lines
14
to
16
| env: | ||
| NODE_OPTIONS: "--max-old-space-size=8192" | ||
| FLY_API_TOKEN: ${{ secrets.PRD_FLY_API_TOKEN }} |
Contributor
There was a problem hiding this comment.
Incomplete Typesense removal — leftover code remains
The CI/CD indexing steps are removed, but several Typesense artifacts still exist in the codebase:
pcweb/components/docpage/navbar/typesense.py— the search UI component that creates a Typesense client and readsTYPESENSE_HOST/TYPESENSE_SEARCH_API_KEYenv varsscripts/typesense_indexer.pyandscripts/synonym_indexer.py— the indexing scriptsscripts/requirements.txt— liststypesense>=0.21.0pyproject.toml— still has"typesense"as a dependency
If Typesense is being fully replaced, these files and references should be cleaned up in this PR (or a follow-up) to avoid dead code. If the search feature is still needed at runtime via a different indexing mechanism, that's worth noting in the PR description.
Alek99
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.