Skip to content

remove typsense#1777

Merged
Alek99 merged 1 commit intomainfrom
carlos/remove-typsense
Mar 16, 2026
Merged

remove typsense#1777
Alek99 merged 1 commit intomainfrom
carlos/remove-typsense

Conversation

@carlosabadia
Copy link
Collaborator

No description provided.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 14, 2026

Greptile Summary

Removes Typesense search indexing from all CI/CD deployment workflows (dev, staging, production) and deletes the standalone typesense-index.yml workflow. This stops the documentation from being indexed into Typesense on each deploy.

  • Removes TYPESENSE_HOST and TYPESENSE_SEARCH_API_KEY environment variables from dev, staging, and production deploy workflows
  • Removes the "Index documentation to Typesense" build step (which installed Typesense dependencies and ran typesense_indexer.py / synonym_indexer.py) from all three deploy workflows
  • Deletes .github/workflows/typesense-index.yml entirely
  • Note: The runtime search component (pcweb/components/docpage/navbar/typesense.py), indexing scripts, and the typesense dependency in pyproject.toml still remain in the codebase and may need cleanup

Confidence Score: 3/5

  • The workflow changes themselves are clean, but removing indexing without removing the search UI may break site search functionality.
  • Score of 3 reflects that while the YAML changes are syntactically correct and the workflow simplification is clean, the Typesense search component still exists in the application code and will attempt to query a Typesense index that is no longer being populated by CI. This could result in stale or empty search results for users. If an alternative search solution is already deployed or search is intentionally being disabled, the score would be higher.
  • Pay attention to pcweb/components/docpage/navbar/typesense.py — it still creates a Typesense client at runtime and may fail or return stale results without the indexing pipeline.

Important Files Changed

Filename Overview
.github/workflows/deploy-dev.yml Removes Typesense env vars and the indexing step from the dev deployment workflow. Clean removal with no syntax issues.
.github/workflows/deploy-prd.yml Removes Typesense env vars and indexing step from production workflow. The runtime search component still references Typesense, so production search may break if no alternative indexing is in place.
.github/workflows/deploy-stg.yml Removes Typesense env vars and indexing step from staging workflow. Same pattern as dev and prod changes.
.github/workflows/typesense-index.yml Deletes the standalone Typesense indexing workflow entirely. No issues with the deletion itself.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Deploy Workflow Triggered] --> B[Checkout & Install]
    B --> C{Before This PR}
    C -->|Yes| D[Install Typesense deps]
    D --> E[Run typesense_indexer.py]
    E --> F[Run synonym_indexer.py]
    F --> G[Deploy to Reflex Cloud]
    C -->|After This PR| G
    G --> H[Site Live]
    H --> I[User Searches Docs]
    I --> J[typesense.py queries Typesense]
    J --> K{Index populated?}
    K -->|Before PR: Yes| L[Search Results Returned]
    K -->|After PR: Stale/Empty| M[⚠️ Potentially Broken Search]

    style D fill:#f88,stroke:#333
    style E fill:#f88,stroke:#333
    style F fill:#f88,stroke:#333
    style M fill:#ff0,stroke:#333
Loading

Last reviewed commit: 23aed10

Comment on lines 14 to 16
env:
NODE_OPTIONS: "--max-old-space-size=8192"
FLY_API_TOKEN: ${{ secrets.PRD_FLY_API_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete Typesense removal — leftover code remains

The CI/CD indexing steps are removed, but several Typesense artifacts still exist in the codebase:

  • pcweb/components/docpage/navbar/typesense.py — the search UI component that creates a Typesense client and reads TYPESENSE_HOST / TYPESENSE_SEARCH_API_KEY env vars
  • scripts/typesense_indexer.py and scripts/synonym_indexer.py — the indexing scripts
  • scripts/requirements.txt — lists typesense>=0.21.0
  • pyproject.toml — still has "typesense" as a dependency

If Typesense is being fully replaced, these files and references should be cleaned up in this PR (or a follow-up) to avoid dead code. If the search feature is still needed at runtime via a different indexing mechanism, that's worth noting in the PR description.

@Alek99 Alek99 merged commit 61ea818 into main Mar 16, 2026
10 checks passed
@Alek99 Alek99 deleted the carlos/remove-typsense branch March 16, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants