Repository navigation
Conversation
The optional eSignet profile ran the Java eSignet authenticator 0.2.0 against the NIA Relay, which no longer matches how eSignet is built and deployed elsewhere. The portal keeps only its mock login. Remove the local and Coolify eSignet compose profiles, the four eSignet images and their release-candidate builds, the portal OIDC code and settings, the nia-esignet Mint client with its generated key and hosted provisioning input, the authenticator pins, the eSignet just recipes and smokes, and the Visitor Center eSignet status entry. Tests now assert the mock-only behaviour. The NIA Relay project and its esignet-userinfo lookup stay: the Relay is part of the five-Relay topology and the project is a governed, compiled package. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
The nia-esignet workload client no longer exists, so its public key should not stay in the published Relay workload JWKS. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The optional eSignet profile ran the Java eSignet authenticator 0.2.0 against the NIA Relay. eSignet is now built and deployed elsewhere as the 2.0 Go line with a native authenticator, so this profile no longer shows how eSignet is used. The portal keeps only its mock login.
Removed
PORTAL_AUTH_PROVIDERis gone too, because only the eSignet code read it; the portal login is now always the mock persona login.nia-esignetMint client: its generated key, its hosted provisioning input, its Bruno request and its public key in the published Relay workload JWKS.justrecipes and smoke scripts, and the Visitor Center eSignet status entry.Kept
esignet-userinfolookup. The Relay is one of the five Relays in the base and hosted topologies and is a governed, compiled package; renaming the lookup needsrelay-check, which this change did not run. Nothing calls the lookup now, and the README and docs say so.Tests
portal/src/routes/auth/auth.test.tscovers the mock login, the persona hint and the fallback for an unknown persona.PORTAL_ESIGNET_*orPORTAL_AUTH_*setting remains.Checks run
All passed before and after unless noted:
ruff,check-fiction.sh,check-config-secrets.py,check-image-pins.py,hosted-image-manifest.py inventory,check-runtime-topology.py,check-registry-stack-release-pin.py,check-signer-public-keys.py.just metadata-publish-checkandmetadata-lint.py, including after the JWKS change.check-hosted-compose.sh,check-coolify-compose.sh, and the staticdocker compose configstep ofjust compose.pnpm check(0 errors),pnpm test(144 tests),pnpm build, and Playwright e2e 8 of 8 (run after the change only).pnpm check(0 errors),pnpm test(62 tests).unittestlist from thejustfile: 239 tests, with one failure that is already onmain:test_smoke_programme_acceptancefails onResourceWarningtext from the generator on stderr.Not run:
relay-checkandevidence-check(they need Docker andrelayctl; the unit tests coveringbuild-cells.pypass), the home live e2e against a full stack (it now expects 17 status entries, all up), the release-candidate workflow and the image builds.After merge
A hosted environment that still sets
PORTAL_AUTH_PROVIDERorPORTAL_ESIGNET_*now ignores them; those variables, the old eSignet images and the eSignet secrets can be removed from it.🤖 Generated with Claude Code