Add safeProtocol as a parameter for defaultUrlTransform#942
Open
janpe wants to merge 2 commits intoremarkjs:mainfrom
Open
Add safeProtocol as a parameter for defaultUrlTransform#942janpe wants to merge 2 commits intoremarkjs:mainfrom
janpe wants to merge 2 commits intoremarkjs:mainfrom
Conversation
github-actions
Bot
added
👋 phase/new
janpe
force-pushed
the
default-url-transform-protocol-parameter
branch
from
18f25d6 to
6c5e56d
Compare
janpe
force-pushed
the
default-url-transform-protocol-parameter
branch
from
6c5e56d to
7af5938
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 1743 1815 +72
Branches 123 131 +8
=========================================
+ Hits 1743 1815 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@remcohaszing @wooorm any thoughts on this suggestion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Allow usage of defaultUrlTransform with custom
safeProtocolregex stringResolves #941