Closed
Conversation
Member
|
This isn't needed due to the existing "include config digest in annotations, and report only if latest pod generation" pattern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem: In HA deployments (replicaCount > 1), SDK pods initialize version-related fields (channel sequence, version label, etc.) from the config file once at startup and never update them. If a pod survives a rollback or restarts at a different time than its peers, it can end up with a stale channel sequence in memory. Both pods then pass the canReport check and send heartbeats every 4 hours at slightly different times, causing the vendor backend to see the instance oscillating between two versions and firing repeated instance.upgraded notifications.
Fix: Added a Kubernetes informer (pkg/secretwatcher) that watches the replicated Secret for updates. When the Secret changes (e.g., after a Helm upgrade), all version-related fields (channelID, channelName, channelSequence, versionLabel, releaseSequence, releaseCreatedAt, releaseNotes) are updated in the in-memory store immediately. This ensures all running replicas converge on the correct version data without requiring a pod restart.
Changes:
Does this PR introduce a user-facing change?