Repository navigation
Fix static linking on ARM64 musl - #1
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM64 musl static executables can fail to link because vendored libuv uses outlined atomics whose support code references
__getauxval. Add-mno-outline-atomicswhen OCaml's compiler configuration identifies ARM64 musl, usingocamlc -configto retain OCaml 4.03 compatibility.Extend the existing CI matrix with Linux x64 and ARM64 static builds. All configurations share checkout, compiler setup, and dependency installation. Static configurations install the current checkout, link a hello-world executable with
-static, verify that it is statically linked, and run it.Validation: local macOS package build and hello-world execution passed (with
lt_cv_sys_max_cmd_len=65536for the restricted sysctl probe); configure-action checks passed for six compiler configurations; CI YAML and all seven matrix entries validated. Linux CI is running on the fork.