fix: update URLs in search box to have trailing slash #1183
+133
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rescript-lang-org with
|
| Latest commit: |
305e36f
|
| Status: | 🚫 Build failed. |
jderochervlk
changed the title
jderochervlk
force-pushed
the
vlk/fix-redirects
branch
2 times, most recently
from
c5f281c to
d2d2a8f
Compare
jderochervlk
force-pushed
the
vlk/fix-redirects
branch
from
d2d2a8f to
9c15c05
Compare
jderochervlk
force-pushed
the
vlk/fix-redirects
branch
from
cde1507 to
de6c3af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell Cloudflare pages require urls to end with a trailing slash.
https://community.cloudflare.com/t/removing-trailing-slash-on-static-websites/583429
https://developers.cloudflare.com/pages/configuration/serving-pages/#route-matching
https://developers.cloudflare.com/rules/page-rules/reference/additional-reference/#zone-name-occurrences-must-end-with-a-slash
This means that absolute url links need to have a trailing slash or they get redirected.
This does not apply to in app navigation since it doesn't hit the edge, but it might be a good idea to normalize those in case people are copy and pasting.
You can see that navigating to https://rescript-lang.org/docs/manual/array-and-list redirects to https://rescript-lang.org/docs/manual/array-and-list/.