Repository navigation
Conversation
The opam override for Luv now fetches commit 8c12b1a of rescript-lang/luv (PR rescript-lang/luv#2) instead of patching the upstream 0.5.14 tarball. The fork vendors libuv 1.53.0 instead of 1.48.0 and already carries the ARM64 musl -mno-outline-atomics fix, so the local patch is gone. The package is versioned 0.5.14+rescript.1 and dune-project/rescript.opam pin that version. Review: Why a git URL and not a release tarball? The fork keeps libuv as a git submodule; GitHub archives omit submodules, while opam's git fetch initializes them. The commit hash should move to the merge commit once rescript-lang/luv#2 lands. Review: Does the OCaml rewatch use any changed Luv API? Only FS_event, Loop, Timer, Handle and Error (native_watcher.ml). The fork's API change (statfs reserved fields read as zero) does not reach it. Area: rewatch ci Output: unchanged Tests: none, because no observable behavior changes; the shared rewatch suite (113 checks, incl. watch mode), the rewatch-ocaml focused suite and scripts/test.js -ounit -build -mocha -docstrings pass on the new libuv Measured: watch edit latency, median of 21 interleaved edits (basic fixture) 99 -> 100 ms, A/A control 98 ms; 400-directory fixture 98 -> 102 ms, A/A control 100 ms; watch cold start, median of 7 (400 dirs) 213 -> 211 ms, A/A 212 ms; idle watcher CPU over 20 s 70-90 ms for all; clean build (400 modules), median of 9, 180 -> 180 ms; linux-arm64 devcontainer under load, job tmp watch_ab.py and clean_ab.py Signed-off-by: Christoph Knittel <ck@cca.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9Q6perkzKBQQebDnVXAEK
The Luv override now fetches 2094c025, the merge commit of rescript-lang/luv#2 and the fork's master tip, instead of the PR head 8c12b1a. Both commits have the same tree (7acc6c6d), so the built sources are identical. Area: ci Output: unchanged Tests: none, because the fetched source tree is identical to the tested one Signed-off-by: Christoph Knittel <ck@cca.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q9Q6perkzKBQQebDnVXAEK
cknitt
force-pushed
the
luv-libuv-1.53
branch
from
October 17, 2026 07:40
80593ac to
20c7647
Compare
cknitt
marked this pull request as ready for review
October 17, 2026 07:40
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
fhammerschmidt
approved these changes
Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the libuv used by the OCaml rewatch from 1.48.0 to 1.53.0 by building Luv from the rescript-lang/luv fork (rescript-lang/luv#2).
.github/opam-repositorynow providesluv.0.5.14+rescript.1, fetched from the fork by commit hash (2094c025, the merge commit of Upgrade libuv to 1.53.0 and test native watcher APIs luv#2).dune-projectandrescript.opampin that version.-mno-outline-atomicsfix, so the local patch is removed.+rescript.2with a new hash.Luv.File.Statfsreserved fields now read as zero) doesn't affect us: rewatch only usesFS_event,Loop,Timer,HandleandErrorinnative_watcher.ml.Performance is unchanged: watch latency, watcher startup, idle CPU and clean builds measured the same as with libuv 1.48 (Linux only; macOS and Windows weren't measured).
No new tests: there's no observable behavior change, and the existing watch tests in the shared rewatch suite cover the watcher.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q9Q6perkzKBQQebDnVXAEK