astc-encoder-py: add build-astc-encoder-py.yml for riscv64 wheels - #1776
Merged
Merged
Conversation
Wraps ARM's astc-encoder (vendored as a git submodule) via a small C extension. Upstream ships no git tags, so the workflow pins the 0.1.12 release commit and verifies it matches the PyPI sdist. The extension is unconditionally built with Py_LIMITED_API, so builds collapse to a single cp37-abi3 wheel per libc (find_compatible_wheel reuses it for cp312/cp313/cp314) and cp314t is dropped since the free-threaded build rejects the limited API. musllinux runs a dependency-free smoke test since the registry has no riscv64 musllinux wheels yet for the upstream test extras.
CPython 3.14 introduced the LOAD_FAST_BORROW opcode, which skips the incref for a local passed straight into a call; test_refcount_cleanup asserts sys.getrefcount(astc_image) == 2 right after such a call, so it now off-by-ones on cp314 regardless of architecture. Confirmed on this branch's own CI: cp312 and cp313 pass the full suite, cp314 fails only this one assertion while every compress/decompress test (including the pil codec ones) passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
astc-encoder-py0.1.12Compiles a small C extension wrapping ARM's astc-encoder (vendored as a git submodule) for texture compression. Upstream publishes no riscv64 wheel.
Mirrors upstream's
release.ymlmanylinux/musllinux jobs.Differs from upstream
Matrix: cp312/cp313/cp314 only - cp314t drops, the extension is unconditionally compiled with Py_LIMITED_API, which the free-threaded build rejects.
Testing
.[tests].License: OK
Built once on cp312; abi3 wheel reused and tested on cp312/cp313/cp314 via find_compatible_wheel.