chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring#4641
chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring#4641NathanFlurry wants to merge 1 commit intochore/remove-wasm-sqlite-native-onlyfrom
Conversation
|
PR Review: chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring Overview This PR removes the WASM SQLite VFS package and its associated workspace wiring. The deleted surface includes:
The intent aligns with the design direction in the deleted spec: move to host-side native SQLite rather than in-isolate WASM. Issues Unintentional pnpm-lock.yaml override (likely a bug) The @rivetkit/engine-api-full workspace override was changed from workspace:* to a pkg.pr.new PR preview URL. This pins CI and developers to an ephemeral commit build on an external service. If that URL expires or the package is removed this will silently break installs. This looks like it was included by accident and should be reverted before merge. PR description is empty All checklist boxes are unchecked and there is no summary. It is worth noting which downstream consumers depended on @rivetkit/sqlite-wasm and confirming they have been migrated or are intentionally left without SQLite support until the native path lands. Test coverage removed without replacement Approx 790 lines of tests are deleted, including:
The lock-repro test covers a property of the Node.js runtime rather than the WASM library, and could be relevant to the native path too. Consider whether it should be migrated. kv.ts key layout reference is now gone CLAUDE.md states the native Rust VFS and the WASM TypeScript VFS must match 1:1, and lists rivetkit-typescript/packages/sqlite-vfs/src/kv.ts as the authoritative TypeScript side. With kv.ts deleted, the native VFS (rivetkit-typescript/packages/sqlite-native/src/kv.rs) has lost its paired reference. Consider either moving the key-layout constants to a shared spec or updating CLAUDE.md to remove the now-stale file reference. docs-internal/engine/NATIVE_SQLITE_DATA_CHANNEL.md not updated CLAUDE.md references this file as the full spec for native/WASM VFS parity. Deleting the WASM implementation without updating that spec may leave it referencing a package that no longer exists. Minor observations
Summary The removal is well-scoped and directionally correct. The blocking concern is the @rivetkit/engine-api-full pkg.pr.new pin in pnpm-lock.yaml -- that should not land on main. The test deletion and missing doc updates are worth addressing before or immediately after merge. |
0bc1a8e to
b7e88da
Compare
7158470 to
9ce9006
Compare
b7e88da to
8a620d1
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: