Skip to content

Uses prop-types npm's package#4

Open
vyzaldysanchez wants to merge 1 commit intormariuzzo:masterfrom
vyzaldysanchez:bug/react-15-prop-types/deprecated
Open

Uses prop-types npm's package#4
vyzaldysanchez wants to merge 1 commit intormariuzzo:masterfrom
vyzaldysanchez:bug/react-15-prop-types/deprecated

Conversation

@vyzaldysanchez
Copy link

@vyzaldysanchez vyzaldysanchez commented Mar 11, 2019

Here's an implementation to not rely on an no longer react included package. Done in order to fix issue #3.

A quick question, since it's not mentioned in the README file: which version of node/npm should be used to develop?

@asvinp
Copy link

asvinp commented Feb 5, 2020

I couldn't seem to get it to work.

I tried forking the original repo, making the changes to the 2 files you mentioned and then using
npm install https://github.com/[user-name]/react-chronos/master
React version - "react": "^16.8.6"
I still seem to get the error:

TypeError: Cannot read property 'oneOf' of undefined

Truly appreciate if you could help me out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments