fix: report plugin coverage instead of the tests module - #107
Merged
Conversation
The e2e step ran -coverpkg=./... from inside tests/, so it instrumented the tests module and the awk filter then dropped every line. The root unit tests never ran in CI at all. Scope coverpkg to the plugin module, add a root unit step, and fail the job when the merged summary holds no plugin blocks.
Copilot stopped reviewing on behalf of
rustatian due to an error
August 17, 2026 15:16
The tests module pinned http/v6 beta.8, which pulls api-go beta.13 and the connect-era protos, while the PHP SDK is on the v1 line. The worker failed to decode the first frame and exited, so the request came back 500. TestFileLogger also asserted on "worker constructed" and "201 GET", neither of which the stack emits: pool logs "worker is allocated" and the http access log is structured, so the status is a "status":201 field. Assert on what the file logger writes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
===========================================
+ Coverage 0 79.35% +79.35%
===========================================
Files 0 5 +5
Lines 0 281 +281
===========================================
+ Hits 0 223 +223
- Misses 0 47 +47
- Partials 0 11 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage has been reporting 0% while the suite has ~1000 lines of tests.
The e2e step ran
-coverpkg=./...from insidetests/, so it instrumented the tests module rather than the plugin. The codecov job was already correct, so the awk prefix filter then dropped every line and the upload arrived empty.format_handler_test.goin the root module also never ran in CI.Scopes coverpkg to
github.com/roadrunner-server/logger/v6/...and adds a root unit step. Locally the corrected profile carries 127 blocks. Adds a guard that fails the job when the merged summary holds fewer than 10 blocks — tokenless uploads fail open, which is why this went unnoticed.Also drops
-failfast.Note this does not fix the intermittent
GPBDecodeException: Unexpected wire typefailures — those come fromcomposer updatere-resolving the PHP SDK on every run and are handled separately once the plugin betas are tagged.