Table view fixes #1544
Merged
Table view fixes #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes visual and layout issues in the table view components by improving dark mode support for filter chips and enhancing the row preview sidebar's header behavior.
Changes:
- Added dark mode styling for filter chips to improve visibility with appropriate dark background colors and white text
- Increased bottom margin of table surface to provide more spacing
- Made the row preview sidebar header sticky and removed unnecessary spacing elements
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/app/components/dashboard/db-table-view/saved-filters-panel/saved-filters-panel.component.css | Updated static filter chip colors for dark mode from light gray to dark blue-gray with proper text contrast |
| frontend/src/app/components/dashboard/db-table-view/db-table-view.component.css | Added dark mode styles for active filter chips and increased table-surface margin-bottom from 24px to 72px |
| frontend/src/app/components/dashboard/db-table-view/db-table-row-view/db-table-row-view.component.html | Removed unnecessary <br /> tag for cleaner spacing |
| frontend/src/app/components/dashboard/db-table-view/db-table-row-view/db-table-row-view.component.css | Made sidebar header sticky with proper positioning, z-index, and padding adjustments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.