Open
Conversation
* Adds diagnostic if no return statement found in function * Added edge cases to tests, and improved returnTypeMismatch check for void rerturns
…hterscript into release-1.0.0
* Does not validate unknown members of a component in BrightScript mode * Fixed lint errors
* Scraped docs and fixed Vector2DFieldInterpolator keyValue type * fixes when the roku docs say instead of * Update scripts/scrape-roku-docs.ts handle whitespace fixes in scraped docs as well Co-authored-by: Bronley Plumb <bronley@gmail.com> * remove duplicated field fix * Is a little more forgiving in getting the return type from the roku docs --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
…1241) * Took a stab at re-writing the docs * Added human readable names to diagnostics * Added file.destPath diagnostics filtering * hopefully fixed test * Is this change needed too? * Changed BsDiagnostic so code is the human-readable version, legacyCode is the old code * Fixed some issues * Fix misspelling * Update docs/bsconfig.md Co-authored-by: Bronley Plumb <bronley@gmail.com> * Update docs/bsconfig.md Co-authored-by: Bronley Plumb <bronley@gmail.com> * Updated docs to use new codes instead of legacy codes for diagnotsics * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Changes from comments on PR * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Combined diagnostics to make new expectedOperator diagnostic * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Combined expectedTerminator diags - Ill Be Back * Consolidated expected statement diagnostics * Removed xml prefix on xml diagnostics * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * use one expected-identifier diaganostic code * A few more changes * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * Update src/DiagnosticMessages.ts Co-authored-by: Bronley Plumb <bronley@gmail.com> * A few more changes * Rename many diagnostic codes * Some small code tweaks * Updated the expectedEndForOrNextToTerminateForLoop diagnostic * Refactored memberAccessibilityMismatch diagnostic * Reverted data.json change * Combine `expectedIdentifierAfterKeyword` and `expectedIdentifier` * Merge several `expected*AfterCallable` diagnostics into `expecteToken` or `expectedIdentifier` * Rename functionNameCannotEndWithTypeDesignator to invalidIdentifier and update diagnostics for invalid characters in function names * Rename mismatchedEndCallableKeyword to closingKeywordMismatch and update related diagnostic messages * More diagnostics refactoring (unterminatedString, class inheritance, etc) * Eliminate more diagnostic codes (such as localVarSameNameAsClass and expectedOpenParenToFollowCallfuncIdentifier) * Refactor hash* diagnostics --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
* Eliminates unnecessary import and fractional hex diagnostics * Adds tests for fractional hex in different contexts --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
* Fixes default type for ArrayLIteral with enum member inner types * Adds a new ReferenceType for Default/initial values
…1296) * Refactored PrintStatment to only use expressions * Introduce new `PrintSeparatorExpression` * Fix some formatting * More specific token type * Just cleaning up some merge issues --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
* Augments handling of void returns * Removed commented out code * Built-in functions that are as void will return UninitializedType
* Makes assignments of invalid act be typed as dynamic * Makes assignments of invalid act be typed as dynamic
* Binary operators on Unions work better now * Used same logic on unary operators as well * Updated test to check result type of complex binrary operation * Binary and Unary operators handle ObjectType - issue #1387
* Fixed completion and hovers on callFUn invocations * Callfunc return types are used for assignments * Callfunc and @invocations return types are honored, as long as they are built in types * Adds Callfunc invocation validation * removed .onlys * Adds component.createChild() typing * fixed some comments * Removed validation errors on generic roSgNode * Perform validation on dependent types when ComponentType changes * added one final test for for revalidation when callfunc type changes * Re-validates references to a component when the callfunc signature changes * Change some comments: * removed commented out code * removed commented out code * Makes componentType checking with builtin components better * Added changed symbols logging -- noticed there's way too many there * Added cannotFindCallFuncFunction and many tests * Found a crash and fixed it * Ensures validation when the unresolved member of a resolved type changes * Added coomments * Better handling of completion and validation of nodes from component libraries * Fixes callfunc on result of function call * Revert change - there's a difference between built in symbols and built in types * Fix build * Fixed issue for callfuncs returning voidtype * Adds count of changed symbols to the validation metrics * Adds protection on not being able to decipher defining nodes for some symbols --------- Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
Co-authored-by: rokucommunity-bot <93661887+rokucommunity-bot@users.noreply.github.com> Co-authored-by: Bronley Plumb <bronley@gmail.com>
…ing typed functions
…atability of optional args in a typed function type
Co-authored-by: Luis Jacobetty Soares <57358121+luis-j-soares@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the official branch for the v1.0.0 release, tracking milesone v1.0.0.