Skip to content

potental perf fix with file cache useage in scope #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisdp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

potental perf fix with file cache useage in scope #1664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/Scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ export class Scope {
}

const key = path.isAbsolute(filePath) ? 'srcPath' : 'pkgPath';
let map = this.cache.getOrAdd('fileMaps-srcPath', () => {
let map = this.cache.getOrAdd(`fileMaps-${key}`, () => {
const result = new Map<string, BscFile>();
for (const file of this.getAllFiles()) {
result.set(file[key].toLowerCase(), file);
Expand Down Expand Up @@ -1206,12 +1206,7 @@ export class Scope {
if (!relativePath) {
return;
}
let files = this.getAllFiles();
for (let file of files) {
if (file.pkgPath.toLowerCase() === relativePath.toLowerCase()) {
return file;
}
}
return this.getFile(relativePath, false);
}

/**
Expand Down