Fix Experimental-related deprecation warnings#40
Closed
enirolf wants to merge 2 commits intoroot-project:mainfrom
Closed
Fix Experimental-related deprecation warnings#40enirolf wants to merge 2 commits intoroot-project:mainfrom
Experimental-related deprecation warnings#40enirolf wants to merge 2 commits intoroot-project:mainfrom
Conversation
hahnjo
requested changes
Feb 28, 2025
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
This will make the reference implementation incompatible with ROOT 6.34 which is the current target (see also https://github.com/root-project/rntuple-validation?tab=readme-ov-file#reference-implementation). The idea is to use that release until a first version of the validation suite.
Contributor
Author
|
Ah that's right, I forgot! Let me also fix it up in #39. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.