Skip to content

Add tests for Real32Trunc#43

Merged
silverweed merged 1 commit intoroot-project:mainfrom
silverweed:real32trunc
May 2, 2025
Merged

Add tests for Real32Trunc#43
silverweed merged 1 commit intoroot-project:mainfrom
silverweed:real32trunc

Conversation

@silverweed
Copy link
Copy Markdown
Contributor

Closes #5

@silverweed silverweed requested review from enirolf and hahnjo April 30, 2025 09:20
@silverweed silverweed self-assigned this Apr 30, 2025
Copy link
Copy Markdown
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values make sense to me, thanks! Apart from two minor comments inline, can you also link the new directory in types/fundamental/README.md?

Comment thread types/fundamental/real32trunc/write.C Outdated
Comment thread types/fundamental/real32trunc/write.C Outdated
@hahnjo hahnjo requested a review from pcanal April 30, 2025 15:48
@hahnjo hahnjo added this to the 1.0 milestone Apr 30, 2025
Comment thread types/fundamental/real32trunc/README.md
@silverweed silverweed merged commit ce8a39a into root-project:main May 2, 2025
1 check passed
@silverweed silverweed deleted the real32trunc branch May 2, 2025 06:44
@hahnjo hahnjo added the types label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test for Real32Trunc column type

3 participants