[math] Remove the pasted ERotation3DMatrixIndex#21592
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 13, 2026
Merged
[math] Remove the pasted ERotation3DMatrixIndex#21592guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
jmcarcell
changed the title
silverweed
reviewed
Mar 13, 2026
Contributor
silverweed
left a comment
silverweed
left a comment
There was a problem hiding this comment.
Thanks for the cleanup PR! I made a comment about the using enum
jmcarcell
force-pushed
the
remove-pasted-enum
branch
from
0b505cd to
1625f4e
Compare
guitargeek
approved these changes
Mar 13, 2026
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
LGTM! I actually like the C++20 "preview" because it tells me immediately that ERotation3DMatrixIndex and Rotation3D::ERotation3DMatrixIndex are 100 % the same.
And as you noted, we have used the pattern before, and I indeed git grepped for __cplusplus when we raised the minimum C++ standard to 17 and was happy that the code got simpler and clearer in some places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a single source for it when needed; more precisely, remove it in files where it's not used. Also prepare for using C++20 where
using enumis allowed and is basically what is being done.