Skip to content

[x11] Fixes in Rotated.cxx#21598

Open
linev wants to merge 1 commit intoroot-project:masterfrom
linev:fix_rotated
Open

[x11] Fixes in Rotated.cxx#21598
linev wants to merge 1 commit intoroot-project:masterfrom
linev:fix_rotated

Conversation

@linev
Copy link
Member

@linev linev commented Mar 13, 2026

  1. Clear all members in RotatedTextItem_t via memset(item, 0). Otherwise some values like fXimage can stay uninitialized.

  2. When create pixmap, provide at least size 1 x 1 - otherwise X11 server may complain

Failure appears with plain TX11 text drawing.
Just add to .rootrc line:

 Gui.Backend: x11

And in the begin of script add:

gVirtualX->SetTextMagnitude(1.1)

Then X11 made a lot of errors like:

Error in <RootX11ErrorHandler>: BadDrawable (invalid Pixmap or Window parameter) (XID: 44040631, XREQ: 55)

And either ROOT crashes or graphics will not work

1. Clear all members in RotatedTextItem_t via memset(item, 0). Otherwise some values like fXimage
can stay uninitialized.

2. When create pixmap, provide at least size 1 x 1 - otherwise X11 server may complain
@github-actions
Copy link

Test Results

    22 files      22 suites   3d 4h 42m 12s ⏱️
 3 807 tests  3 805 ✅ 1 💤 1 ❌
76 714 runs  76 704 ✅ 9 💤 1 ❌

For more details on these failures, see this check.

Results for commit eb631b4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants