[Python][RF] Set correct Python-side ownership to function return values#21600
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 14, 2026
Merged
[Python][RF] Set correct Python-side ownership to function return values#21600guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
vepadulano
approved these changes
Mar 13, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thank you for the quick fix! LGTM if the CI is green.
We still have no mechanism to annotate C++ signatures to flag to cppyy that the returned value needs to be manually deleted. Thils should be prioritized after the current upgrade to the new compiler toolchain. Until then, RooFit methods need to be manually Pythonized for clear ownership to avoid memory leaks, such as the one reported on the forum: https://root-forum.cern.ch/t/how-to-clean-delete-properly-roodataset-in-pyroot/64749
guitargeek
force-pushed
the
set_ownership
branch
from
27de10a to
87a8aa0
Compare
Test Results 22 files 22 suites 3d 1h 47m 18s ⏱️ For more details on these failures, see this check. Results for commit 87a8aa0. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still have no mechanism to annotate C++ signatures to flag to cppyy that the returned value needs to be manually deleted. Thils should be prioritized after the current upgrade to the new compiler toolchain.
Until then, RooFit methods need to be manually Pythonized for clear ownership to avoid memory leaks, such as the one reported on the forum:
https://root-forum.cern.ch/t/how-to-clean-delete-properly-roodataset-in-pyroot/64749