Repository navigation
Conversation
Configure a timeout for connecting to the RootlessKit API socket, and set an idle connection timeout on the HTTP transport. Previously, idle connections had no expiration because IdleConnTimeout was left at its zero value. This could leave connections open indefinitely for callers that create short-lived clients without explicitly closing idle connections. Use the same dial and idle connection timeouts as http.DefaultTransport. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
Author
|
cc @AkihiroSuda |
AkihiroSuda
reviewed
Oct 2, 2026
| } | ||
|
|
||
| dialer := &net.Dialer{ | ||
| Timeout: 30 * time.Second, |
Member
There was a problem hiding this comment.
Should this be passed from the caller as an option like WithTimeout() ?
Contributor
Author
There was a problem hiding this comment.
Don't think so (or at least it would be a separate feature) I used the same defaults as http.DefaultTransport. Or at least to my understanding, this client is created as the equivalent to the default, but with the connection-string modified.
For timeouts, callers can already use context cancellation.
Same for the other timeout, which also aligns with stdlib.
Member
There was a problem hiding this comment.
I used the same defaults as http.DefaultTransport
Please add a comment line to refer to it?
AkihiroSuda
reviewed
Oct 2, 2026
| return d.DialContext(ctx, "unix", socketPath) | ||
| return dialer.DialContext(ctx, "unix", socketPath) | ||
| }, | ||
| IdleConnTimeout: 90 * time.Second, |
Member
There was a problem hiding this comment.
maybe:
Suggested change
| IdleConnTimeout: 90 * time.Second, | |
| IdleConnTimeout: dialer.Timeout * 3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure a timeout for connecting to the RootlessKit API socket, and set an idle connection timeout on the HTTP transport.
Previously, idle connections had no expiration because IdleConnTimeout was left at its zero value. This could leave connections open indefinitely for callers that create short-lived clients without explicitly closing idle connections.
Use the same dial and idle connection timeouts as http.DefaultTransport.