fix: FeatureChecker was swapped with Arc<FeatureChecker>, breaking broadcast_channel #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utyfua
changed the title
utyfua
changed the title
utyfua
commented
Aug 21, 2025
src/inner_runtime.rs
Outdated
| .rt_mut() | ||
| .op_state() | ||
| .borrow_mut() | ||
| .put(Arc::new(feature_checker)); |
Contributor
Author
There was a problem hiding this comment.
Before
.put(eature_checker);This is the only line i did change.
I did format the file cuz I got failed workflow
Owner
There was a problem hiding this comment.
I think it's just the line endings, it's a git setting
Owner
|
Looks perfect except that I think something went wrong with your line endings! It shows every single line is being changed haha Also can you bump the version number? Then it's good to publish the update |
Contributor
Author
Idk cuz i just ran
Sure |
…oadcast_channel (7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #386